Add `MastForest::advice_map` for the data required in the advice provider before execution

0xPolygonMiden / miden-vm

STARK-based virtual machine

MIT License

632 stars 161 forks source link

Add `MastForest::advice_map` for the data required in the advice provider before execution #1574

Closed greenhat closed 1 day ago

greenhat commented 1 week ago

This PR implements VM-facing part of #1547 and adds advice map to the MastForest that is loaded in the advice provider when the MastForest executed.

This PR contains changes exposing AdviceProvider in Host (see commit) introduced in #1572 (see comment)

greenhat commented 2 days ago

@plafer Thank you for the review! I addressed all the comments. Please do another round.

greenhat commented 2 days ago

Let's hold off on merging this temporarily while we figure out with #1572 how we want the Host/AdviceProvider API to look like

No problem! I'll keep an eye on #1572