search

0xPolygonZero / plonky2

Apache License 2.0
777 stars 289 forks source link

Fix run_syscall in interpreter. #1351

Closed LindaGuiga closed 11 months ago

LindaGuiga commented 12 months ago

We noticed that in the interpreter, the program counter that is stored corresponds to program_counter + 1 outside of the interpreter, so we fix this in run_syscall on the interpreter side. We also remove the unnecessary self.run in run_syscall. We update the sload test to catch this error.

sonarcloud[bot] commented 12 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information