Closed LindaGuiga closed 9 months ago
or no row for an empty byte sequence
Are empty byte sequences possible now?
or no row for an empty byte sequence
Are empty byte sequences possible now?
When running add11, I noticed some operations had empty byte sequences (I did not change the way operations are added, so I assume they were already there). But no row was added in that case either, because there was a for
loop on the sequence's elements
Good to merge (after the fix on log_opcode test :) )
Kudos, SonarCloud Quality Gate passed!
This PR changes the way
BytePackingStark
generates its rows: it generates only one row per operation (or no row for an empty byte sequence). It reduces greatly the number of rows: for add11_yml, we go from 119,388 to 20,028 rows inBytePackingStark
. This also leads to fewer constraints and one less column.