0xPolygonZero / plonky2

Apache License 2.0
757 stars 283 forks source link

Remove extra rows in BytePackingStark #1388

Closed LindaGuiga closed 9 months ago

LindaGuiga commented 9 months ago

This PR changes the way BytePackingStark generates its rows: it generates only one row per operation (or no row for an empty byte sequence). It reduces greatly the number of rows: for add11_yml, we go from 119,388 to 20,028 rows in BytePackingStark. This also leads to fewer constraints and one less column.

Nashtare commented 9 months ago

or no row for an empty byte sequence

Are empty byte sequences possible now?

LindaGuiga commented 9 months ago

or no row for an empty byte sequence

Are empty byte sequences possible now?

When running add11, I noticed some operations had empty byte sequences (I did not change the way operations are added, so I assume they were already there). But no row was added in that case either, because there was a for loop on the sequence's elements

Nashtare commented 9 months ago

Good to merge (after the fix on log_opcode test :) )

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information