search

0xPolygonZero / plonky2

Apache License 2.0
777 stars 289 forks source link

Remove intermediary block bloom filters #1395

Closed Nashtare closed 11 months ago

Nashtare commented 11 months ago

This PR removes the computation of the intermediary bloom filters pre & post transaction execution. The block bloom is kept as PI and consistency check is maintained as part of BlockMetadata::connect within aggregation proofs. The transaction bloom logic is unchanged.

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

dvdplm commented 11 months ago

The block bloom is kept as PI and consistency check is maintained as part of BlockMetadata::connect within aggregation proofs.

Can you help me understand this better? What is PI?

Nashtare commented 11 months ago

PI is public inputs. We keep the bloom filter included in the block header (the final bloom), but we don't construct it internally anymore