search

0xPolygonZero / plonky2

Apache License 2.0
777 stars 289 forks source link

Update stack op cost #1402

Closed Nashtare closed 11 months ago

Nashtare commented 11 months ago

Updates the cost evaluation for stack operations, as some have changed since the top of the stack move to CPU table. Also removes the TODO related to PUSH cost as it seems correct now that PUSH constraints induce 1 Memory read per byte.

Gains are clearly negligible, but at least it's coherent with the underlying implementation.

closes #1332

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information