search

0xPolygonZero / plonky2

Apache License 2.0
758 stars 281 forks source link

Add IS_READ column to BytePacking CTL #1430

Closed hratoanina closed 9 months ago

hratoanina commented 9 months ago

In the CPU <-> BytePacking CTL, we were not checking whether the operation was a byte packing (with memory writes) or a byte unpacking (with memory reads). This could lead to unwanted writes in memory.

sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Nashtare commented 9 months ago

Unless that's a bug on my end, it seems you've included this commit by mistake on the ERC-721 PR?