Remove full memory channel

0xPolygonZero / plonky2

Apache License 2.0

755 stars 278 forks source link

Remove full memory channel #1450

Closed hratoanina closed 8 months ago

hratoanina commented 8 months ago

Following https://github.com/0xPolygonZero/plonky2/pull/1426, we can now remove a memory channel.

This allows us to remove 13 CPU columns (down to 85), at the cost of some CTL columns:

For SET_CONTEXT, we use two CPU CTL columns to write the old stack length and read the new stack length.
For syscalls and exceptions, we bundle the three contiguous jumptable reads with one CPU CTL column.

hratoanina commented 8 months ago

@Nashtare @dvdplm I introduced the disabling functions for this file only, but it can be extended to the whole codebase (and put in a new utils file). I'll do it in another PR to not crowd this one though.

Nashtare commented 8 months ago

Why don't you put it already in cpu_stark.rs, similarly to where the utility get_addr is? Not sure having a PR just to move this around is useful.. And that would allow other submodules in CPU to leverage it.

sonarcloud[bot] commented 8 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud