Fix bugs in jumpdest analysis - Githubissues

0xPolygonZero / plonky2

Apache License 2.0

755 stars 278 forks source link

Fix bugs in jumpdest analysis #1474

Closed 4l0n50 closed 7 months ago

4l0n50 commented 7 months ago

This PR incorporates the following changes:

Fix test_jumpdest_analysis which was previously not meaningful, as it only verified that jumpdest_analysis never aborted though that can't happen. Now, it verifies the correctness of SEGMENT_JUMPDEST_BITS and of jumpdest_table.
Introduce test_packed_verification.

The PR addresses the bugs uncovered during these tests, primarily:

Utilizing the current context instead of the one in the stack in PROVER_INPUT(jumpdest_table::).
Correcting the prefix computation in the packed verification of write_table_if_jumpdest.

sonarcloud[bot] commented 7 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud