search

0xPolygonZero / plonky2

Apache License 2.0
755 stars 278 forks source link

Use web-time crate #1481

Closed vivekvpandya closed 7 months ago

vivekvpandya commented 7 months ago

Use web-time crate (https://github.com/daxpedda/web-time) instead of std version. It works for wasm32 targets too. If target support time in std then it's just an alias to that.

dlubarov commented 7 months ago

Did you try with the timing feature off, or is that not a good option as you want the timing breakdown?

vivekvpandya commented 7 months ago

Did you try with the timing feature off, or is that not a good option as you want the timing breakdown?

I tried with default-features=false, features=["std"] but it did not worked.

but in any case I think this PR is harmless.

Nashtare commented 7 months ago

If we're to add full timing support for wasm targets, then I'd suggest using web-time, as this issue properly suggests: https://github.com/sebcrozet/instant/issues/52.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

vivekvpandya commented 7 months ago

@Nashtare anything more needed to be done for this PR? if not could you please merge it.