0xPolygonZero / plonky2

Apache License 2.0
755 stars 278 forks source link

Refactor Access Lists #1487

Closed 4l0n50 closed 6 months ago

4l0n50 commented 7 months ago

The list of accessed addresses and storage keys are now stored as a sorted linked list. In this way insertion and deletion can be done non-deterministically in O(1) cycles, instead of the previous O(|list|) cycles. For erc20 it goes from arithmetic_len: 14372, byte_packing_len: 17334, cpu_len: 65800, keccak_len: 12696, keccak_sponge_len: 529, logic_len: 4496, memory_len: 364123 to arithmetic_len: 14365, byte_packing_len: 17063, cpu_len: 64971, keccak_len: 12768, keccak_sponge_len: 532, logic_len: 4530, memory_len: 362246

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Nashtare commented 6 months ago

closing in favor of https://github.com/0xPolygonZero/zk_evm/pull/30