Fix no-std tests and add corresponding jobs in the CI

0xPolygonZero / plonky2

Apache License 2.0

745 stars 273 forks source link

Fix no-std tests and add corresponding jobs in the CI #1501

Closed Nashtare closed 5 months ago

Nashtare commented 5 months ago

We currently do check that plonky and starky crates compile well in no-std for WASM targets, but it'd be nice to also make sure we can actually run their test suites in no-std to make sure the internal logic isn't broken.\

This PR fixes a bunch of missing conditional imports to make tests pass in no-std, and adds two more CI jobs for testing the two mentioned crates.

Nashtare commented 5 months ago

@pgebheim Could you update the required jobs for PRs to be mergeable?

I updated the wasm job for consistent naming with others
I added a new no-std job that probably should be required

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

muursh commented 5 months ago

@pgebheim Could you update the required jobs for PRs to be mergeable?

I updated the wasm job for consistent naming with others

I added a new no-std job that probably should be required

Done