Implement Hermez SMT - Githubissues

wborgeaud commented 5 months ago

Implement the Hermez SMT and replace the state MPT with a state SMT.

Still TODO:

Implement PoseidonStark, reusing code from #1311.
Implement Hermez's Poseidon sponge and check codehash in load_code.
Fix tests in evm/src/cpu/kernel/tests/mpt/*.
Figure out what to do with SEFLDESTRUCT.

For some context on the last one, I think it's impossible to correctly implement SELFDESTRUCT with this SMT design, because we can't clear the storage of an account. Polygon zkEVM replaced SELFDESTRUCT with SENDALL, so we could do the same. Otherwise, we could fast track EIP-6780 (included in Cancun) which modifies SELFDESTRUCT in a way that we can implement with this SMT.

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Nashtare commented 5 months ago

Closing in favor of https://github.com/0xPolygonZero/zk_evm/pull/34

0xPolygonZero / plonky2

Implement Hermez SMT #1512

Quality Gate passed