0xPolygonZero / plonky2

Apache License 2.0
745 stars 273 forks source link

Increase testing in starky crate #1514

Open Nashtare opened 5 months ago

Nashtare commented 5 months ago

The starky crate doesn't have much unit tests, and would benefit from a stronger test suite covering the different setups that can be used.

shreyas-londhe commented 4 months ago

Hi @Nashtare, I'm interested in working on this, can you please guide me on what needs to be done?

Nashtare commented 4 months ago

Hey @shreyas-londhe! Thanks for your interest in this! It's mostly about testing the cross-functionalities between different scenarios at the moment. We currently support testing simpler STARKs with:

We do lack of CTLs test strentghening, which involve defining some simple system across 2 or 3 tables operating on common values. We'd probably need some consistency checks around challenge computations and quotient polynomial evaluation for badly used parameters cases (like not specifying a requires_ctls for a table in a multi-STARK for instance).

We'd probably also need some higher-degree test cases for STARKs, valid & invalid cases ideally. But not everything has to be done at once, this can be a long-running task :) Let me know if you have any additional question!

Nashtare commented 3 months ago

@shreyas-londhe Do you need help on this?