search

0xPolygonZero / plonky2

Apache License 2.0
745 stars 273 forks source link

Fix CTLs with exactly two looking tables #1555

Closed Nashtare closed 4 months ago

Nashtare commented 4 months ago

The way helper columns were computed was truncating the resulting vector for n = 2, resulting in quotient polynomial check failure.

closes #1554

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Nashtare commented 4 months ago

Yeah I noticed it while fixing, but would probably be requiring more refactor and I wanted a quick fix :')