0xPolygonZero / plonky2

Apache License 2.0
753 stars 278 forks source link

Remove unstable features #417

Open nbgl opened 2 years ago

nbgl commented 2 years ago

We should work towards making Plonky2 compile on stable.

Unstable features that need to either be removed from Plonky2 or that need to be stabilized in Rust:

unzvfu commented 1 year ago

Removed the generic_const_exprs feature from the field crate in #1020 and from the plonky2 crate in #1024.

Nashtare commented 1 year ago

Would the EVM crate also be aimed for compiling on stable? If so, we'd need to remove the let_chains and generic_const_exprs features. The first one would be easy to do, and perf. penalty (if any) by the two nested loops wouldn't be an issue as this is only used for building the Kernel. Removing the latter would be more painful though.

eightfilms commented 12 months ago

I'm also assuming here that the same goal is desired in starky? But that means that Stark::COLUMNS and Stark::PUBLIC_INPUTS have to be removed.