Incorrect documentation on `GenerationInputs::signed_txns`

0xPolygonZero / zk_evm

Apache License 2.0

86 stars 38 forks source link

Incorrect documentation on `GenerationInputs::signed_txns` #555

Closed 0xaatif closed 2 months ago

0xaatif commented 3 months ago

https://github.com/0xPolygonZero/zk_evm/blob/32a6ba7f6d7773d0b9873aa116f4aab26b1bfb38/evm_arithmetization/src/generation/mod.rs#L68-L70

Clearly wrong, this isn't an Option, I'm not sure what the correct phrasing would be

Nashtare commented 3 months ago

Yeah missed leftover from continuations upgrade. There is also some renaming that should come soon on the decoder side (ProcessedTxnInfo -> ProcessedBatchInfo and similar). They could all be addressed together