search

0xPolygonZero / zk_evm

Apache License 2.0
79 stars 32 forks source link

Adding lints to CI #587

Open 0xaatif opened 2 weeks ago

0xaatif commented 2 weeks ago

Good stuff. May I suggest you also use the opportunity to add the lint to our CI, so we cannot merge code that violates this rule going forward?

_Originally posted by @einar-polygon in https://github.com/0xPolygonZero/zk_evm/pull/571#issuecomment-2329159352_

0xaatif commented 2 weeks ago

Moving here because I think it's a separate change to the PR in question

It's a fair suggestion, but I think adding lints to CI, especially when they're only at nursery level is something we should avoid doing.

einar-polygon commented 2 weeks ago

I wasn't aware of the nursery status, and it's a good point. We could either add it in the future or add it now and allow it it emit a warning. I don't have a strong preference.

On a side node, I would like to introduce the shadow_unrelated lint to our codebase at some point.

einar-polygon commented 1 week ago

Perhaps this as well trivially_copy_pass_by_ref.