search

0xPolygonZero / zk_evm

Apache License 2.0
85 stars 37 forks source link

pin toolchain #660

Closed 0xaatif closed 1 month ago

0xaatif commented 1 month ago

WIBNI reproducible CI

https://github.com/0xPolygonZero/zk_evm/actions/runs/11017223235/job/30594596343

Here we fail on the default branch due to a compiler regression

0xaatif commented 1 month ago

Note we already do this for mdbook, not sure what the best upgrade strategy for this is (I don't think dependabot can handle it just yet)

Could do a weekly cron-ed PR

Nashtare commented 1 month ago

Could do a weekly cron-ed PR

If we want to pin the toolchain (which may very well needed given latest mdbook issues and possibly unforeseen incoming ones), then I'd tend to opt for some cron-ed job to keep it relatively up-to-date, at least while we're heavily developing, but this seems tedious if we cannot automate the actual version bump.

0xaatif commented 1 month ago

Would save us from https://github.com/rust-lang/rust-clippy/issues/13458 which is blocking #659 and #564

0xaatif commented 1 month ago

Would save us from rust-lang/rust-clippy#13458 which is blocking #659 and #564

$ git show --pretty=reference --no-patch
56e7d08e (feat: trie diff tool (#630), 2024-09-24)

$ for day in 25 26; do
>    toolchain=nightly-2024-09-$day
>    rustup install $toolchain &>/dev/null
>    echo $toolchain
>    CARGO_TARGET_DIR=target.$toolchain.ignoreme cargo +$toolchain clippy --all-targets --quiet
> done
nightly-2024-09-25
nightly-2024-09-26
warning: unneeded `return` statement
...
0xaatif commented 1 month ago

(I promise I didn't break clippy to push this issue, despite the suspicious timing :D)