search

0xPolygonZero / zk_evm

Apache License 2.0
85 stars 37 forks source link

feat(test): Canned RPC provider #745

Closed 0xaatif closed 1 week ago

0xaatif commented 3 weeks ago

For #728 and general testability.

atanmarko commented 3 weeks ago

Alloy provider is very complex trait, covering the whole node API. Mocking the JSON response that Provider would return is very tedious, hard, error prone and quite unnecessary for our tests (we do not intend to test alloy parsers implementation - we work on the level of alloy api objects - e.g. Block).

I am against going this path. It is going down the rabbit hole.

0xaatif commented 1 week ago

I still believe in this but it's not a priority right now