search

0xPolygonZero / zk_evm

Apache License 2.0
85 stars 37 forks source link

Fix bytecode hashing for Type2 SMT #782

Closed Nashtare closed 1 week ago

Nashtare commented 1 week ago

@0xaatif I took a shot at #779 because it was starting to collide with what I was doing on the type2 branch, please let me know what you think.

Also we'd like to move World trait and related structs to evm_arithmetization instead of the trace_decoder for easy reuse across case disjunction on the prover side. Do you have any objection? If not I could even add it to this PR.

0xaatif commented 1 week ago

Also we'd like to move World trait and related structs to evm_arithmetization instead of the trace_decoder for easy reuse across case disjunction on the prover side. Do you have any objection? If not I could even add it to this PR.

No objection, @LindaGuiga has already run this past me :) evm_arith is definitely the correct place for it if it's going to be used by both crates :)