search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Metamask not installed #117

Closed pablofullana closed 5 years ago

pablofullana commented 5 years ago

As a user, when not having Metamask installed, I'd like to get a message stating so.

Is this possible or shall this be taken care with the 'Unlock Metamask' issue (#116)? Open for discussion.

Image 2019-03-07 at 5.27.29 PM.png

fvictorio commented 5 years ago

I think we can distinguish between MetaMask not being installed (there's now window.web3 or window.ethereum) and MetaMask not being unlocked (the time between calling provider.enable and the promise it returns being resolved).

We already have a Web3State enum, I think we can expand them to better represent all possible scenarios. Once we have that and the proper value is in the store, then implementing this is just a matter of checking that value.

pablofullana commented 5 years ago

Sounds perfect.