Missing/Locked Metamask on action

0xProject / 0x-launch-kit-frontend

Apache License 2.0

114 stars 208 forks source link

Missing/Locked Metamask on action #118

Closed pablofullana closed 5 years ago

pablofullana commented 5 years ago

As a user not having Metamask installed or having it locked, when trying to perform an action that will require Metamask, I'd like to get a modal stating to install/uninstall it.

Draft list of actions:

[ ] Limit Buy
[ ] Limit Sell
[ ] Market Buy
[ ] Market Sell ...

Could all these actions be taken care of as the first step of each complex flow? Open for discussion.

Image 2019-03-07 at 5.30.06 PM.png

fvictorio commented 5 years ago

Could all these actions be taken care of as the first step of each complex flow? Open for discussion.

I'd say no. If you have to install/enable MetaMask, then you have to refresh the page after doing it, so it doesn't make sense to have this as a first step in the flow IMO.

pablofullana commented 5 years ago

Agreed. Let keep it out then.

pablofullana commented 5 years ago

Closing in favor of #159