search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Markets prices #166

Closed fvictorio closed 5 years ago

fvictorio commented 5 years ago

Closes #104.

This PR shows the price for each market in the dropdown. The price of a given pair is obtained by getting all its ask orders (through getOrderbookAsync) and then using the first one to compute the price. The reason for this is that, according to the SRA spec, the ask orders are sorted by cheapest price first. However, the relayer we are using is not compliant with this requirement; there's an open bug related to that, so you'll see the price of the first sell order that was created.

I also removed all content related to daily price changes and volumes.

Agupane commented 5 years ago

@fvictorio could you check the conflicts? thanks

fvictorio commented 5 years ago

Conflicts resolved.