0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

(Bug) Locked/Unlocked token icon it's updated before the transaction finish #176

Closed Agupane closed 5 years ago

Agupane commented 5 years ago

If an user tries to lock/unlock tokens, once he generated the transaccion, the lock/unlock icon is automatic updated before the transaction ends (and therefore, before the modal closes).

In the image below, one can see that the with lock icon is unlocked, but the unlocking operation did still not finished image

If the user quits the app during the transation approval time, he will see the old icon again (which is ok). But in that case, the UI is not updated once the transaction finished, only if the user reload the app, the new icon will be displayed

How to test: 1- Go to my wallet 2- Select a token and press "lock/unlock" button 3- Accept the transaction on metamask

Note: this error could only be noted outside localhost, otherwise the transaction approve will be to fast that seems working ok.