0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

(Feature) Restored original size of orderbook and orders component #188

Closed Agupane closed 5 years ago

Agupane commented 5 years ago

Closes #186

Keep the current layout with orders and orderbook, but changes the sizes of the components

It looks like this: image

fvictorio commented 5 years ago

I don't think this is the right way of doing this, since the semantic of the components it's now lost. I think we have to change the width of MainContent, and maybe create a new sidebar component RightSideBar (or some other name) with the proper width.

@gabitoesmiapodo wdyt?

gabitoesmiapodo commented 5 years ago

@fvictorio @Agupane

Yeah, that would be more appropriate.

And don't forget some margin to separate the columns.

gabitoesmiapodo commented 5 years ago

@Agupane

You could use something more generic, like ColumnNarrow ColumnWide etc. if you don't want to associate the container's name with a fixed position.

Agupane commented 5 years ago

It's done, please let me know if it's ok, I'd updated the photo with the result @gabitoesmiapodo @fvictorio

fvictorio commented 5 years ago

Two comments:

gabitoesmiapodo commented 5 years ago

@Agupane

The separation between columns 1 / 2 is wider than the separation between columns 2 / 3.

Try to make it the same.

Agupane commented 5 years ago

@fvictorio @gabitoesmiapodo It's done, thanks! image