0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Make networkId mandatory in getKnownTokens #204

Closed fvictorio closed 5 years ago

fvictorio commented 5 years ago

We had some places where we were calling getKnownTokens without arguments. This was making it default to using the ganache network id, and that was being cached and used for the remaining calls. So Kovan wasn't working properly because the test tokens addresses were being used.

My solution was to make that parameter mandatory, but that triggered a lot of other changes. I think it's necessary, but there might be a better way to handle this (specifically: we are using getKnownTokens for things that don't depend on the network). We can think about that later.