Spinners keep spinning when requests timeout / fail

0xProject / 0x-launch-kit-frontend

Apache License 2.0

114 stars 208 forks source link

Spinners keep spinning when requests timeout / fail #239

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #225

How to test it:

Initialize the Dapp without docker
This is a video of the expected behavior https://www.useloom.com/share/5a381933459b4dc293281408bb96a7d5

fvictorio commented 5 years ago

I don't understand the fix, could you explain it?

mariano-aguero commented 5 years ago

I don't understand the fix, could you explain it?

In case of an error in the web3 status, the load was always displayed. This causes the problem described in the title of the issue. To avoid this situation, we validate that the spinner is displayed only when there is no web3 status error