Use placeholder text instead of actual text in buy/sell inputs

0xProject / 0x-launch-kit-frontend

Apache License 2.0

114 stars 208 forks source link

Use placeholder text instead of actual text in buy/sell inputs #250

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #236

mariano-aguero commented 5 years ago

R: Could you fix this warning please?

NaN removed, so this problem should not happen anymore

Regards

fvictorio commented 5 years ago

The way this was done was not allowing the user to input something like 0.01. The first 0 was being ignored.

I added a commit to make nullable the makerAmount and price state variables of buy_sell. When they are null, this is interpreted as "empty". I tested several scenarios and all of them worked.