search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

(Feature) Review modal texts #279

Closed Agupane closed 5 years ago

Agupane commented 5 years ago

Closes #276

Agupane commented 5 years ago

@chriskalani we have a question regarding the market step modal:

In order to display the amount of tokens received on a fill market operation in the steps modals, we need to calculate it first. And since multiple orders could be filled with a single market opreation, each of these having different prices, we are not completely sure how to come up with a single price to display in the message x token received:

image

Using the minimum value is an option, an alterative would be to the display the average price, among other options. Which do you think is the best approach here?

unjapones commented 5 years ago

We may have to proceed like the other question-labeled PRs: if they don't get an answer in a couple of days, we might go ahead with the merge and create an issue for the particular question so that we don't block the entire set of changes.