search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Revisit buy/sell step modal with correct calculation #285

Closed Agupane closed 5 years ago

Agupane commented 5 years ago

In order to display the amount of tokens received on a fill market operation in the steps modals, we need to calculate it first. And since multiple orders could be filled with a single market operation, each of these having different prices, we are not completely sure how to come up with a single price to display in the message x token received:

image

Using the minimum value is an option, an alterative would be to display the average price, among other options. Which do you think is the best approach here?

Based on this PR

unjapones commented 5 years ago

cc @chriskalani

chriskalani commented 5 years ago

Let's just remove this text for now. I don't think we need to solve this.