0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Show exchanged token amount in market buy sell step #302

Closed unjapones closed 5 years ago

unjapones commented 5 years ago

Closes #285.

Depending on the operation, the footer should show:

  • if performing a buy, the base token sum: "I'm buying NN ZRX" => footer is "NN ZRX received".
  • if performing a sell, the quote token sum: "Im selling NN ZRX" => footer is "WW wETH received".

Also sneaked in this fix:

Screenshots:

Footer in last buy/sell market step: sell_footer

_Orange color in Sell tab of buysell: orange_sell

fvictorio commented 5 years ago

I created a buy order of 100 ZRX at price 0.01 wETH, and then I sold 10 ZRX in market. I got this message:

0 wETH received

instead of 0.1 wETH. Is this expected?

unjapones commented 5 years ago

I created a buy order of 100 ZRX at price 0.01 wETH, and then I sold 10 ZRX in market. I got this message:

0 wETH received

instead of 0.1 wETH. Is this expected?

Mmmm, there is something wrong with the calculation, I'll take a look. Will re-request review when I' done