search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

(Feature) Shows myWallet information even if the relayer is down #303

Closed Agupane closed 5 years ago

Agupane commented 5 years ago

Closes #297 Closes #277 Closes #296 If there is an error related with the relayer, now we display the wallet balance information if it's available. Also improves the logging when there is an error with the relayer and with web3

How to test: 1- Modify the REACT_APP_RELAYER_URL env var in order to get an error when trying to reach the relayer 2- Open the dApp and go to myWallet

It should look like this:

image

Note that the api call to the relayer has failed (console) but the wallet balance is displayed.

Note: this PR also closes this issue

The dashboard, looks like this now:

image

mariano-aguero commented 5 years ago

NB comment: It may be a good idea to capture the error and show it with the logging tool,

Agupane commented 5 years ago

@mariano-aguero What you told it's not part of the issue #296, the issue #296 aims to solve this comment:

The [HPM] Error occurred while trying to proxy request /v2/orders?makerAssetData=0xf47261b0000000000000000000000000e41d2489571d322189246dafa5ebde1f4699f498&page=1&takerAssetData=0xf47261b0000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2 from localhost:3001 to http://localhost:3000 (ECONNREFUSED) (https://nodejs.org/api/errors.html#errors_common_system_errors) when you don't have a launch kit instance running are a bit jarring, can we make these nicer?

See this

mariano-aguero commented 5 years ago

@mariano-aguero What you told it's not part of the issue #296, the issue #296 aims to solve this comment:

The [HPM] Error occurred while trying to proxy request /v2/orders?makerAssetData=0xf47261b0000000000000000000000000e41d2489571d322189246dafa5ebde1f4699f498&page=1&takerAssetData=0xf47261b0000000000000000000000000c02aaa39b223fe8d0a0e5c4f27ead9083c756cc2 from localhost:3001 to http://localhost:3000 (ECONNREFUSED) (https://nodejs.org/api/errors.html#errors_common_system_errors) when you don't have a launch kit instance running are a bit jarring, can we make these nicer?

See this

Yes but not resolve the comment I said, I think that's why we should not close that issue since we expect the comment of the description to be resolved (everything it says)

unjapones commented 5 years ago

Yes but not resolve the comment I said, I think that's why we should not close that issue since we expect the comment of the description to be resolved (everything it says)

@mariano-aguero regarding #296, we decided to improve the message shown in the browser console/logging. I think this issue covers that.

If there is another thing, I believe it should be covered by other tickets related with the comment (the message has a lot of items).