Replace units functions with Web3Wrapper methods

0xProject / 0x-launch-kit-frontend

Apache License 2.0

114 stars 208 forks source link

Replace units functions with Web3Wrapper methods #304

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Changes applied:

Replace function tokenAmountInUnits by toUnitAmount
Replace function unitsInTokenAmount by toBaseUnitAmount
Added orderSizeInUnits to manage size of orders (nbt token) , if we use the webWrapper functions will throw an exception (see)

unjapones commented 5 years ago

I've just saw some strange behavior while interacting with the UI. I want to double-check this with @mariano-aguero before merging the PR.

unjapones commented 5 years ago

@mariano-aguero looks good. There are conflicts though.

If you want another review after the conflicts-solving, feel free to re-request one.

mariano-aguero commented 5 years ago

@mariano-aguero looks good. There are conflicts though.

If you want another review after the conflicts-solving, feel free to re-request one.

Done, re-request review

mariano-aguero commented 5 years ago

Found another thing while manually testing: there is a strange exception when interacting with the "price per token" input.

Done!

unjapones commented 5 years ago

Found an unexpected behavior with the big_number_input on the eth/weth dialog conversion (when you focus it, it will shoul you the amount of eth or weth in base units).

I don't feel comfortable with the changes/adaptations we applied to big_number_input: the component usage is turning counter-intuitive. We should probably check the interaction of the component and its consumers and then apply this PR's changes/objective.