Notifications should link to Etherscan

0xProject / 0x-launch-kit-frontend

Apache License 2.0

114 stars 208 forks source link

Notifications should link to Etherscan #308

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #306

This PR adds:

Constants to etherscan in kovan and mainnet
Link in notifications items to etherscan
Hover state for notifications items

mariano-aguero commented 5 years ago

Requested a change and posted a question regarding limit notifications.

If we agree on "limit notifications should not be clickable", the implementation may be tricky because hovering them should not style the cursor as pointer. Probably, the wrapper of the whole notification may have to become an anchor with target="_blank"(for items that link to etherscan) or a normal div/whatever otherwise.

Added some logic to the notification wrapper to solve this tricky problem.

Regards