0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Add notifications #326

Closed fvictorio closed 5 years ago

fvictorio commented 5 years ago

Similar to the ERC20 marketplace, we should show notifications when some things happen.

This should probably be done after both the sale and the buy features are implemented (#314 and #316). There's also a notification for delisting an asset (#315).

fvictorio commented 5 years ago

AFAIK we are not going to do this. Notifications in ERC20 were a pain and we had to go through a lot of hoops to make them work. The underlying problem is that this is something really hard to do in the frontend. I think similar arguments to there apply. I'm closing it; please re-open if you disagree.