0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

ERC20 and ERC721 routes split #331

Closed unjapones closed 5 years ago

unjapones commented 5 years ago

Blocked by #327: we should resolve themes things first (at least, the basics). Connects #311.

Description

To test this, you can either go to http://{host:port}/erc20 and http://{host:port}/erc721`. Accessinghttp://{host:port}` should redirect you to the erc20 app by default.

Includes

Does not include/TODO:

fvictorio commented 5 years ago
  • Adapt GeneralLayout to accept custom renderToolbar: erc20_app and erc721_app will have to provide their corresponding toolbar (which is different in both apps).

Very minor, but maybe it would be a little better to just pass a component instead of a function, unless that function may receive some arguments from the component that uses it. What do you think?

unjapones commented 5 years ago

Removing the blocked-by label: rebased using development to get the Dark Theme.

fvictorio commented 5 years ago

@unjapones changed the base branch of the PR to erc721.