(Feature) Sell collectibles button

Agupane commented 5 years ago

Closes #323

It looks like this:

Note: as I explained on my comment bellow, the "sell" button on the header should be styled on another pr, where all the styling of the headers is done

fvictorio commented 5 years ago

If the search doesn't match anything, a spinner is shown instead of some message.

fvictorio commented 5 years ago

Also: maybe we shouldn't show collectibles that are already for sale?

Agupane commented 5 years ago

It's done @fvictorio, now the modal display an "empty component" if no results were found. Also only displays the collectibles that are not already on sale.

unjapones commented 5 years ago

Overall, I believe it is good enough.

After we finish with the corresponding PRs, we can discuss the naming and component's folder structure in erc721 because (at least for me) the names are a little bit confusing. We can probably go with something like:

collectibles_details/
    price_badge.tsx.
    collectibles_details_item_list.tsx
    collectibles_details_item_tile.tsx
    collectibles_details_list.tsx
collectibles_list/
    collectibles_card_list.tsx
    collectibles_list.tsx
    collectibles_sort_filter/
        collectibles_list_filter.tsx
        collectibles_list_sort.tsx
common/
    [...]
pages/
    [...]
modals/
    collectible_list_modal.tsx
    collectible_sell_modal.tes
    sell_collectibles_button.tsx
[...]

We'll see later, after we finish with the other PRs.

0xProject / 0x-launch-kit-frontend

(Feature) Sell collectibles button #416