0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

(Feature) ERC20 Default theme as dark #426

Closed Agupane closed 5 years ago

Agupane commented 5 years ago

Closes #420 Adds support for having at the same time different themes for each app (ERC20 and ERC721). Each route has now a default theme (white for erc721 and dark for erc20).

Each application have their own ThemeProvider with their own theme

fvictorio commented 5 years ago

The way this is implemented seems unnecessarily complex to me. Couldn't we just move the ThemeProvider inside each of the app components and use the proper constant there?

Agupane commented 5 years ago

I have made the refactor as you suggested @fvictorio, It was a good idea, it's better now, please check it

Agupane commented 5 years ago

The readme it's updated now @mariano-aguero