0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Remove explicit gas limit #446

Closed fvictorio closed 5 years ago

fvictorio commented 5 years ago

We are using a hardcoded gas limit in a lot of calls. This is a problem in mainnet since metamask shows an unreasonable number (above 1 USD for example) for transactions that shouldn't cost that.

This might cause problems in ganache when the estimated gas is off. If that happens, we can use this limit only during development.