0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

ETH:wETH Converting error #503

Closed burnsben closed 5 years ago

burnsben commented 5 years ago

ETH:wETH conversion is a bit jank at the moment

Getting this error after trying to wrap eth.

Screen Shot 2019-05-30 at 10 27 20 AM

Also this happened yesterday

Screen Shot 2019-05-29 at 2 24 02 PM
burnsben commented 5 years ago

^for that second screenshot, those weren't my actual balances, it changed to 100 wETH randomly.

mariano-aguero commented 5 years ago

Hi @burnsben, I think the problem is that previously there was an account change on metamask, and the account was not reset before the transaction, could you tell me if the problem persists? In case of Yes, could you share the steps to reproduce the issue?.

Regards

Screenshot_20190531_142801

burnsben commented 5 years ago

Not sure what you mean by account change, the only changes I've made in metamask are switching from mainnet to kovan.

Problems happen when I go back and forth between converting.

Here, I only have 7.33 ETH, but it's showing an inflated total

Screen Shot 2019-05-31 at 12 31 35 PM
burnsben commented 5 years ago

Going from full 7.33 ETH, to a split of ETH: wETH gave me this error again

Screen Shot 2019-05-31 at 12 26 37 PM
burnsben commented 5 years ago

wait sorry I got that reversed, that was trying to go from a split to full 7.33 ETH

burnsben commented 5 years ago

the issue of showing the 10.3 amount is temporary-- there's a lag in calculating the individual amounts.

unjapones commented 5 years ago

@burnsben the UI allows to open the conversion modal and funky things may happen while the wrap transaction is still pending. Just to name one, the ETH/WETH balances shown are not 100% accurate since a wrap is happening.

Should we disable the button that opens the wrap modal until the transaction has been confirmed? I believe this will reduce the chance of unexpected events.

burnsben commented 5 years ago

@unjapones These errors happen after it says the transaction has completed successfully. Perhaps these success states are not correct?

Screen Shot 2019-06-04 at 10 28 47 AM