search

0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

Forwarder usage does not handle fees #557

Open dekz opened 5 years ago

dekz commented 5 years ago

When using the Forwarder fee orders are never used, so any order with ZRX fees will fail.

0xProject/0x-launch-kit#22

            if (isMarketBuyForwarder) {
                txHash = await contractWrappers.forwarder.marketBuyOrdersWithEthAsync(
                    ordersToFill,
                    amount,
                    ethAccount,
                    ethAmountRequired,
                    [], // no fee orders
                    0,
                    ZERO_ADDRESS,
                    getTransactionOptions(gasPrice),
                );
            }