0xProject / 0x-launch-kit-frontend

Apache License 2.0
114 stars 208 forks source link

layout - columns fix #560

Open adekbadek opened 5 years ago

adekbadek commented 5 years ago

before: bug

after: fix

dekz commented 5 years ago

Thanks for the submission @adekbadek. It appears you cannot scroll now when the page is of very small resolution (but still desktop render).

adekbadek commented 5 years ago

With this proposed solution the columns are scrollable:

But come to think of it, it might make more sense to just not force the footer to be at the bottom of the viewport and live with with the fact the it will not always be visible:

sc

WDYT?

dekz commented 5 years ago

@adekbadek hah I just had my cursor just a hair outside when I was testing it out. This looks fine to me, I'll take a deep look this week and hopefully get this in.