Closed artiya4u closed 5 years ago
Thank you for the bug report @artiya4u. You are indeed correct that this is a bug. Will fix ASAP.
I try to send the order to RadarRelay without validation but it seems like the relay won't accept our order either. Could this bug cause the problem?
@artiya4u I'm pretty sure they are using our validation method (which includes the same bug). I will publish today and let them know.
Just published a new version of @0x/order-utils
with this fixed: https://github.com/0xProject/0x-monorepo/releases/tag/monorepo%4096b8100
I create an order with a wallet smart contract and validate it with order-utils using validateOrderFillableOrThrowAsync but it threw an unreadable error.
Expected Behavior
It should send the signature without type to validate on wallet contract.
Current Behavior
Send the signature type to validate from wallet smart contract wallet instead of the signature. I have dig into the code and found const signatureWithoutType is actually the type (04).
Possible Solution
The code should be like this
Steps to Reproduce (for bugs)
Context
I try to build a copy trading on 0x protocol with a smart contract wallet.
Your Environment
Linux, NodeJS v10.14.1
| Package | Version | |
@0x/order-utils
| 3.0.4 | |Exchange Contract
| v2 |