0xProject / 0x-monorepo

0x protocol monorepo - includes our smart contracts and many developer tools
Other
1.41k stars 467 forks source link

TransformerDeployer: Fix `kill()` interface mismatch. #2624

Closed dorothy-zbornak closed 4 years ago

dorothy-zbornak commented 4 years ago

Description

The current TransformerDeployer.die() is calling Transformer.kill(), which does not exist. We actually want to call Transformer.kill(address payable ethRecipient). This PR fixes this.

We also now throw a revert error in deploy() if the create() opcode returns a null address, which indicates a constructor revert.

TODO before merging:

Testing instructions

Types of changes

Checklist:

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

dorothy-zbornak commented 4 years ago

Merged into #2657