The current TransformerDeployer.die() is calling Transformer.kill(), which does not exist. We actually want to call Transformer.kill(address payable ethRecipient). This PR fixes this.
We also now throw a revert error in deploy() if the create() opcode returns a null address, which indicates a constructor revert.
TODO before merging:
[ ] Redeploy TransformerDeployer
[ ] Have governor call TransformERC20.setTransformerDeployer() to new TransformerDeployer instance on all networks.
[ ] Update contract-addresses.
Testing instructions
Types of changes
Checklist:
[ ] Prefix PR title with [WIP] if necessary.
[ ] Add tests to cover changes as needed.
[ ] Update documentation as needed.
[ ] Add new entries to the relevant CHANGELOG.jsons.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Description
The current
TransformerDeployer.die()
is callingTransformer.kill()
, which does not exist. We actually want to callTransformer.kill(address payable ethRecipient)
. This PR fixes this.We also now throw a revert error in
deploy()
if thecreate()
opcode returns a null address, which indicates a constructor revert.TODO before merging:
TransformerDeployer
TransformERC20.setTransformerDeployer()
to newTransformerDeployer
instance on all networks.contract-addresses
.Testing instructions
Types of changes
Checklist:
[WIP]
if necessary.