Feature/bunny hop - Githubissues

0xProject / 0x-monorepo

0x protocol monorepo - includes our smart contracts and many developer tools

Other

1.41k stars 467 forks source link

Feature/bunny hop #2647

Closed moodlezoup closed 4 years ago

moodlezoup commented 4 years ago

Description

Testing instructions

Types of changes

Checklist:

[x] Prefix PR title with [WIP] if necessary.
[x] Add tests to cover changes as needed.
[x] Update documentation as needed.
[x] Add new entries to the relevant CHANGELOG.jsons.

moodlezoup commented 4 years ago

Yeah, I think this approach is fine as an MVP, contingent on the sims looking good.

On another note, I feel like AS is at its breaking point with the amount of twisty edge casing and union types going on but idk how to keep building on it in the short term without making it worse. After this, I'm thinking we should do a feature freeze until a refactor happens.

agreed. we should definitely refactor once we freeze v0