[Price-aware RFQ requests] Decouple QuoteReporter from _generateOptimizedOrdersAsync

0xProject / 0x-monorepo

0x protocol monorepo - includes our smart contracts and many developer tools

Other

1.41k stars 467 forks source link

[Price-aware RFQ requests] Decouple QuoteReporter from _generateOptimizedOrdersAsync #2713

Closed PirosB3 closed 4 years ago

PirosB3 commented 4 years ago

Description

Decouples the quote reporter logic from generating an optimized order. This PR is simply a refactor in lieu of greater changes that will happen in separate PRs. There should be no impact on the end user.

Testing instructions

Types of changes

Refactor

Checklist:

[X] Prefix PR title with [WIP] if necessary.
[X] Add tests to cover changes as needed.
[X] Update documentation as needed.
[ ] Add new entries to the relevant CHANGELOG.jsons.

PirosB3 commented 4 years ago

@steveklebanoff which tests are you referring to? MarketOperationUtils tests are all passing for me