feat: Refactor rfq comparison price integration

0xProject / 0x-monorepo

0x protocol monorepo - includes our smart contracts and many developer tools

Other

1.41k stars 464 forks source link

feat: Refactor rfq comparison price integration #2720

Closed PirosB3 closed 3 years ago

PirosB3 commented 3 years ago

Description

Calculates a "price to beat" that can be funneled to RFQ makers. For now, this is naively the price of the overall order. Adds an extra comparisonPrice parameter to the RFQ GET request.

Testing instructions

Added an end-to-end unit test
Will perform testing locally

Types of changes

Checklist:

[X] Prefix PR title with [WIP] if necessary.
[X] Add tests to cover changes as needed.
[X] Update documentation as needed.
[X] Add new entries to the relevant CHANGELOG.jsons.

PirosB3 commented 3 years ago

NOTE: this PR will never build until https://github.com/0xProject/quote-server/pull/8 is merged and released