fix: [asset-swapper] excludedFeeSources. DODO Trade Allowed - Githubissues

0xProject / 0x-monorepo

0x protocol monorepo - includes our smart contracts and many developer tools

Other

1.41k stars 464 forks source link

fix: [asset-swapper] excludedFeeSources. DODO Trade Allowed #2731

Closed dekz closed 3 years ago

dekz commented 3 years ago

Description

https://github.com/0xProject/0x-monorepo/pull/2730 Enabled fee sources to be static and not result in Uniswap being excluded. Therefor we could likely get a maker/ETH taker/ETH price.

Unfortunately this means it is queried on Ganache tests and results in a revert.

I've added the ability to provide excludedFeeSources so that they can be disabled in tests or environments where it doesn't exist.

Testing instructions

Types of changes

Checklist:

[ ] Prefix PR title with [WIP] if necessary.
[ ] Add tests to cover changes as needed.
[ ] Update documentation as needed.
[ ] Add new entries to the relevant CHANGELOG.jsons.