Rfqt comparison feature flag

0xProject / 0x-monorepo

0x protocol monorepo - includes our smart contracts and many developer tools

Other

1.41k stars 464 forks source link

Rfqt comparison feature flag #2735

Closed PirosB3 closed 3 years ago

PirosB3 commented 3 years ago

Description

Adds a feature flag that allows us to roll out the "price-aware RFQ" feature once that data proves that we are ready to do so.

Did end-to-end testing on my local copy of 0x API

[X] Prefix PR title with [WIP] if necessary.
[X] Add tests to cover changes as needed.
[X] Update documentation as needed.
[X] Add new entries to the relevant CHANGELOG.jsons.

coveralls commented 3 years ago

Coverage increased (+0.08%) to 78.711% when pulling 61bf93aac2fe8edbe45bc6a8a31941db21df88e9 on rfqt_comparison_feature_flag into 1cfdc490218f597215290d2f6e8fbf96b4a530b8 on refactor_rfq_comparison_price_integration.

PirosB3 commented 3 years ago

Thank you so much for the help Gene, as discussed earlier I would rather get this in now, and I will be responsible for cutting out the feature-flag code once the feature has been deployed.