search

0xProject / 0x-monorepo

0x protocol monorepo - includes our smart contracts and many developer tools
Other
1.41k stars 466 forks source link

sol-compiler update link for solc binary downloads #2741

Closed gabririgo closed 3 years ago

gabririgo commented 3 years ago

Expected Behavior

sol-compiler should be able to pull latest solc binanries (>0.7.2+)

new list seems to be found here: https://solc-bin.ethereum.org/bin/list.json

affected code line can be found here: https://github.com/0xProject/tools/issues/5

Current Behavior

currently fetching from https://ethereum.github.io/solc-bin/bin/list.json, which has github rate limits

Possible Solution

change link to https://solc-bin.ethereum.org/bin/list.json another positive is it does not have rate limits, which have been affecting sol-compiler

Steps to Reproduce (for bugs)

1. run smart contract package with sol-compiler
2. use solc v.0.7.4
3. trying to compile a contract will return an error

Context

trying to upgrade package using solc 0.5.9 to 0.7.4 0.7.4 has dynamic array storage bugfix

Your Environment

| Package | Version | | sol-compiler: | :4.1.1 -> 4.2.7 |

Network
testrpc
stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gabririgo commented 3 years ago

Closing, as after this issue, 0x team has promptly updated and published the package